Skip to content

Add a method to authenticate via an action token #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

asbfall
Copy link

@asbfall asbfall commented Dec 23, 2024

Description

We would like to extend the hps client to allow an authentication via an action token.

Checklist

  • I have tested these changes locally.
  • I have added unit tests (if appropriate).
  • I have added necessary documentation or updated existing documentation.
  • I have linked the issue(s) addressed by this PR if any.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 8.10811% with 34 lines in your changes missing coverage. Please review.

Project coverage is 86.64%. Comparing base (a34f147) to head (869fa6a).

Files with missing lines Patch % Lines
src/ansys/hps/client/authenticate.py 5.55% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   87.64%   86.64%   -1.00%     
==========================================
  Files          65       65              
  Lines        2929     2965      +36     
==========================================
+ Hits         2567     2569       +2     
- Misses        362      396      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alijawadfahs alijawadfahs requested a review from Buzz1167 April 29, 2025 08:31
@alijawadfahs
Copy link
Collaborator

Two important notes:
1- This new approach requires a new tailored Keycloak that supports job action tokens
2- These functions are tested as a part of the REP scaler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants